chore: Migrate doctor command to TypeScript (3)

[thib92]

Summary:

Finish the healthchecks migration to TS, continuing the work from #712 and #716 (linked to #683):

• androidSDK
• iosDeploy
• nodeJs
• packageManagers
• watchman

Test Plan:

• CI is green ✅
• The changes made make sense

[thib92]

Tests are failing because of the androidSdk healthcheck, because here:

https://github.com/thib92/react-native-cli/blob/2ff26561138c1a7c4e71687dc0a12d4f00f20b9b/packages/cli/src/commands/doctor/healthchecks/androidSDK.ts#L20

We check for sdks === 'Not Found', but it is never the case as the typings describe them as:

'Android SDK': {
  'API Levels': string[];
  'Build Tools': string[];
  'System Images': string[];
  'Android NDK': string;
};

@lucasbento do you know if 'Not Found' is actually a possible value for the Android SDK key?

[thymikee]

@thib92 I think envinfo may output a string "Not Found" when a certain required environment info is not available (looks like it happens on Windows at least, but make sure to check the envinfo codebase or typings)

[thib92]

Thanks @thymikee, I’ll take a look!

[lucasbento]

do you know if 'Not Found' is actually a possible value for the Android SDK key?

@thib92: yeah, it is, you can check it out here.

[thib92]

Thanks. I’ll update the typings then.

[thib92]

Ideally, we should contribute these typings to the envinfo repo. There are no typings yet in there. There is an ongoing PR, but the typings are quite incomplete.

[thib92]

CI is failing but doesn't seem related 🤔

[thib92]

@thymikee is there a way to "try again" on Azure Pipeline? I ran the E2E tests locally and they worked. It might just be an "infrastructure bug" while it ran the test.

[Esemesek]

@thib92 Tests on Windows seem to fail every now and then. I wouldn't care too much C:

[Esemesek]

LGTMT. Thank you for your contribution <3

[thib92]

@Esemesek I guess you figured it out after the comments, but the function types are not needed here because we already have the HealthCheckInterface, so everything is implicit 😄

[Esemesek]

@thib92 Yup. Figured it out C: