fix: config fails to load with --platform flag #2470
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When dependency does not have
platforms
property in dependency config, theconfig
command was breaking when passing--platform [platformName]
when it was trying to readplatforms
from such dependencies.E.g. @react-native-webapis/web-storage contains
react-native.config.js
file whereplatforms
are not defined, so config was breaking when trying to access it.Closes #2463
Test Plan:
node ./path-to-cli/cli/build/bin.js config --platform ios
node ./path-to-cli/cli/build/bin.js config --platform android
Checklist