Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add version to welcome screen #2434

Merged

Conversation

okwasniewski
Copy link
Contributor

Summary:

This PR adds a version to the welcome screen when the user uses a custom one.

This is helpful when testing older versions of React Native (to make sure we are initializing the correct one). It also follows the scheme that Metro does welcoming us with the version. As an extension, we could potentially fetch the latest version from npm and display it but I didn't want to add additional API call. So we display version only if user passed a custom one.

Without explicit version (latest)

CleanShot 2024-06-25 at 10 13 13@2x

With explicit version

CleanShot 2024-06-25 at 10 13 36@2x

Test Plan:

Test out init command

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Verified

This commit was signed with the committer’s verified signature.
florianduros Florian Duros
@okwasniewski okwasniewski force-pushed the feat/welcome-version branch from a07d6c1 to 983cacb Compare June 26, 2024 08:08
@thymikee thymikee merged commit ebbf215 into react-native-community:main Jun 27, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants