fix: react-native RC2 fixes #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Removing ~ npm version range from the template looking for installs > 0.75.0. This effectively forces version pinning against the react native release version. For example: npx @react-native-community/cli init Foo --version 0.75.0-rc2 Would install @react-native-community/[email protected] template only. We have a plan to do something more comprehensive, but this is affecting the release and had to be paused. There are 2 exceptions: - nightly - always points to the nightly tag - 0.75.0-rc.1 - points to 0.75.0-rc.1.1 to unblock the RC1 release 2. Fixed a bug which disabled using --template and --version for installs > 0.75.0, as the release candidates were < 0.75.0.
blakef
force-pushed
the
fix/rc2-release-fixes
branch
from
d5dad7c to
0d3f7e3
Compare
2 tasks
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Would install @react-native-community/[email protected] template only. We have a plan to do something more comprehensive, but this is affecting the release and had to be paused. There are 2 exceptions:
Test Plan:
node ./packages/cli/build/bin.js init RN075 --version 0.75.0-rc.1, but since 0.75.0-rc.1 hasn't been released yet, when you come to install inRN075npm askes you for other versions. If you install 0.75.0-rc.0 it works, which gives me more confidence for 0.75.0-rc.1's release.node ./packages/cli/build/bin.js init RN075 --version nightlynode ./packages/cli/build/bin.js init RN075 --version next- will only work once we do the react-native RC1 release.--versionand--template.Checklist