-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable pausing handling keystrokes in watch mode #2041
Merged
thymikee
merged 3 commits into
react-native-community:main
from
szymonrybczak:feat/enable-pausing-handling-keystrokes
Aug 10, 2023
Merged
feat: enable pausing handling keystrokes in watch mode #2041
thymikee
merged 3 commits into
react-native-community:main
from
szymonrybczak:feat/enable-pausing-handling-keystrokes
Aug 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
thymikee
reviewed
Aug 9, 2023
thymikee
reviewed
Aug 9, 2023
thymikee
reviewed
Aug 9, 2023
thymikee
reviewed
Aug 9, 2023
thymikee
reviewed
Aug 9, 2023
thymikee
requested changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nits and this is good to go
thymikee
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In this PR I created
KeyPressHandler
that allows us to pause handling keystrokes because in nearest future we will add interactive prompts tostart
command, so they will run in watch mode. If we do not pause the handling keystrokes, the "focus" will be on the prompt. I created a function that wrapsprompts
and pauses and resumes interactivity in watchMode.Test Plan:
a
,i
,d
,r
) and check if keystrokes are properly handled.Checklist