Remove useless simulator check in parseXctraceIOSDevicesList

[simonkoeck]

Summary:

I was just sitting 4h in front of the computer debugging why my metro bundler couldn't find the device. :D

Although the xcrun xctrace list devices returned me all the correct devices.

== Devices ==
Pauls & Simons Mac (*****)
iPhone von Simon (15.4.1) (****)

Right before that I uninstalled all my simulators. Now because of the simulator check, the function returned an empty array.

[adamTrz]

Thank's for the PR @simonkoeck
Looks like super edge case having deleted all your simulators, but don't see it would brake anything 😉

Edit: Please fix failing tests as well :)

[simonkoeck]

Fixed :)

[adamTrz]

One question @simonkoeck - what would happen if there're also no physical devices connected?

[simonkoeck]

One question @simonkoeck - what would happen if there're also no physical devices connected?

The function would still return the correct simulators. Only if no simulators and no devices are connected, the function returns an empty array

[adamTrz]

One question @simonkoeck - what would happen if there're also no physical devices connected?

The function would still return the correct simulators. Only if no simulators and no devices are connected, the function returns an empty array

Yeah yeah, I know that 😉
Sorry, not being more precise, what would happen for whole run-ios command? Since we don't have any devices nor simulators available it would definitely fail, but where? Could you test it please?