[#683] convert copyFiles from flow to typescript (#690)

* convert copyFiles from flow to typescript * add ts-ignore for FIXME comment * fix flow-check
react-native-community · Sep 10, 2019 · cc2697a · cc2697a
1 parent ed6205b
commit cc2697a
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 7 deletions.
diff --git a/packages/cli/src/commands/init/__tests__/editTemplate.test.js b/packages/cli/src/commands/init/__tests__/editTemplate.test.js
@@ -5,6 +5,7 @@ import fs from 'fs-extra';
 import snapshotDiff from 'snapshot-diff';
 import slash from 'slash';
 import walk from '../../../tools/walk';
+// $FlowFixMe - converted to TS
 import copyFiles from '../../../tools/copyFiles';
 import {changePlaceholderInTemplate} from '../editTemplate';
 

diff --git a/packages/cli/src/commands/init/__tests__/template.test.js b/packages/cli/src/commands/init/__tests__/template.test.js
@@ -9,6 +9,7 @@ import {
   copyTemplate,
   executePostInitScript,
 } from '../template';
+// $FlowFixMe - converted to TS
 import * as copyFiles from '../../../tools/copyFiles';
 
 const TEMPLATE_NAME = 'templateName';

diff --git a/packages/cli/src/commands/init/template.js b/packages/cli/src/commands/init/template.js
@@ -3,6 +3,7 @@ import execa from 'execa';
 import path from 'path';
 import * as PackageManager from '../../tools/packageManager';
 import {logger} from '@react-native-community/cli-tools';
+// $FlowFixMe - converted to TS
 import copyFiles from '../../tools/copyFiles';
 import replacePathSepForRegex from '../../tools/replacePathSepForRegex';
 

diff --git a/...cli/src/tools/__tests__/copyFiles.test.js → ...cli/src/tools/__tests__/copyFiles.test.ts b/...cli/src/tools/__tests__/copyFiles.test.js → ...cli/src/tools/__tests__/copyFiles.test.ts
diff --git a/packages/cli/src/tools/copyFiles.js → packages/cli/src/tools/copyFiles.ts b/packages/cli/src/tools/copyFiles.js → packages/cli/src/tools/copyFiles.ts
@@ -3,16 +3,15 @@
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- *
- * @flow
  */
 
 import fs from 'fs';
 import path from 'path';
+// @ts-ignore FIXME after converting walk to typescript
 import walk from './walk';
 
 type Options = {
-  exclude?: Array<RegExp>,
+  exclude?: Array<RegExp>;
 };
 
 /**
@@ -21,10 +20,10 @@ type Options = {
 async function copyFiles(
   srcPath: string,
   destPath: string,
-  options?: Options = {},
+  options: Options = {},
 ) {
   return Promise.all(
-    walk(srcPath).map(async absoluteSrcFilePath => {
+    walk(srcPath).map(async (absoluteSrcFilePath: string) => {
       const exclude = options.exclude;
       if (exclude && exclude.some(p => p.test(absoluteSrcFilePath))) {
         return;
@@ -63,7 +62,11 @@ function copyFile(srcPath: string, destPath: string) {
 /**
  * Same as 'cp' on Unix. Don't do any replacements.
  */
-function copyBinaryFile(srcPath, destPath, cb) {
+function copyBinaryFile(
+  srcPath: string,
+  destPath: string,
+  cb: (err?: Error) => void,
+) {
   let cbCalled = false;
   const {mode} = fs.statSync(srcPath);
   const readStream = fs.createReadStream(srcPath);
@@ -79,7 +82,7 @@ function copyBinaryFile(srcPath, destPath, cb) {
     fs.chmodSync(destPath, mode);
   });
   readStream.pipe(writeStream);
-  function done(err) {
+  function done(err?: Error) {
     if (!cbCalled) {
       cb(err);
       cbCalled = true;