Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(default-storage): Privacy manifest missing key #1076

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

krizzu
Copy link
Member

@krizzu krizzu commented Mar 20, 2024

Summary

Apparently, even if the SDK does not collect any data, the Privacy manifest requires that entry to be there, even if with an empty array ¯_(ツ)_/¯

@krizzu krizzu requested a review from tido64 as a code owner March 20, 2024 10:37
Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I didn't expect this. Good catch 👍

@krizzu krizzu enabled auto-merge (squash) March 20, 2024 10:42
@krizzu krizzu merged commit c4ed1fa into main Mar 20, 2024
10 checks passed
@krizzu krizzu deleted the fix/privacy-file-missing-key branch March 20, 2024 10:55
@AsyncStorageBot
Copy link
Collaborator

🎉 This PR is included in version 1.23.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

krizzu added a commit that referenced this pull request Apr 8, 2024
* chore(deps): bump follow-redirects from 1.15.4 to 1.15.6 (#1074)

* feat(default-storage): Add Privacy Manifest for iOS (#1075)

privacy file

* chore(release): 1.23.0 [skip ci]

* fix(default-storage): Privacy manifest missing key (#1076)

add missing key

* chore(release): 1.23.1 [skip ci]

* chore(deps): bump webpack-dev-middleware from 5.3.3 to 5.3.4 (#1077)

Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4.
- [Release notes](https://github.com/webpack/webpack-dev-middleware/releases)
- [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md)
- [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4)

---
updated-dependencies:
- dependency-name: webpack-dev-middleware
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: GH workflows, turbo and other chores (#1073)

* explicit prettierrc

* turbo

* format test

* pull-request workflow

* update actions

* bump to yarn 4

* build script

* init

* examples

* comments

* fix glob

* namespace

* windows build

* fixing windows action

* android example search for node_modules

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: AsyncStorageBot <[email protected]>
krizzu added a commit that referenced this pull request Apr 8, 2024
* chore(deps): bump follow-redirects from 1.15.4 to 1.15.6 (#1074)

* feat(default-storage): Add Privacy Manifest for iOS (#1075)

privacy file

* chore(release): 1.23.0 [skip ci]

* fix(default-storage): Privacy manifest missing key (#1076)

add missing key

* chore(release): 1.23.1 [skip ci]

* chore(deps): bump webpack-dev-middleware from 5.3.3 to 5.3.4 (#1077)

Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4.
- [Release notes](https://github.com/webpack/webpack-dev-middleware/releases)
- [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md)
- [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4)

---
updated-dependencies:
- dependency-name: webpack-dev-middleware
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: GH workflows, turbo and other chores (#1073)

* explicit prettierrc

* turbo

* format test

* pull-request workflow

* update actions

* bump to yarn 4

* build script

* init

* examples

* comments

* fix glob

* namespace

* windows build

* fixing windows action

* android example search for node_modules

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: AsyncStorageBot <[email protected]>
krizzu added a commit that referenced this pull request Apr 10, 2024
sqlite-storage: scaffold workspace (#1071)

* chore(deps): bump follow-redirects from 1.15.4 to 1.15.6 (#1074)

* feat(default-storage): Add Privacy Manifest for iOS (#1075)

privacy file

* chore(release): 1.23.0 [skip ci]

* fix(default-storage): Privacy manifest missing key (#1076)

add missing key

* chore(release): 1.23.1 [skip ci]

* chore(deps): bump webpack-dev-middleware from 5.3.3 to 5.3.4 (#1077)

Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4.
- [Release notes](https://github.com/webpack/webpack-dev-middleware/releases)
- [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md)
- [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4)

---
updated-dependencies:
- dependency-name: webpack-dev-middleware
  dependency-type: indirect
...




* chore: GH workflows, turbo and other chores (#1073)

* explicit prettierrc

* turbo

* format test

* pull-request workflow

* update actions

* bump to yarn 4

* build script

* init

* examples

* comments

* fix glob

* namespace

* windows build

* fixing windows action

* android example search for node_modules

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: AsyncStorageBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants