Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue: resetField sets same object as both defaultValues and formValues, breaking state updates #11328

Closed
1 task done
geeee opened this issue Dec 21, 2023 · 0 comments · Fixed by johnchoi96/johnchoi96.github.io#169 · 4 remaining pull requests
Closed
1 task done

issue: resetField sets same object as both defaultValues and formValues, breaking state updates #11328

geeee opened this issue Dec 21, 2023 · 0 comments · Fixed by johnchoi96/johnchoi96.github.io#169 · 4 remaining pull requests

Comments

@geeee
Copy link
Contributor

geeee commented Dec 21, 2023

Version Number

7.49.2

Codesandbox/Expo snack

https://codesandbox.io/p/sandbox/adoring-cdn-lsvhgf

Steps to reproduce

  1. Go to https://codesandbox.io/p/sandbox/adoring-cdn-lsvhgf
  2. Make sure isFormDirty and isFieldDirty are updated on text input
  3. Click on Reset Field button
  4. Observe isFormDirty and isFieldDirty no longer working properly, always showing false

Expected behaviour

isDirty should continue to work after resetField(), same as it does after reset()

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@geeee geeee changed the title resetField sets same object as both defaultValues and formValues, breaking state updates issue: resetField sets same object as both defaultValues and formValues, breaking state updates Dec 21, 2023
geeee added a commit to geeee/react-hook-form that referenced this issue Dec 21, 2023
@geeee
fix react-hook-form#11328 resetField with object as defaultValue
20e9e5b
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
rafaelcalhau pushed a commit to rafaelcalhau/react-hook-form that referenced this issue May 5, 2024
@geeee @rafaelcalhau
🐞 fix react-hook-form#11328 resetField with object as defaultValue (r…
0f66ca0 
…eact-hook-form#11329)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade react-hook-form from 7.49.3 to 7.51.5 johnchoi96/johnchoi96.github.io
[Snyk] Upgrade react-hook-form from 7.48.2 to 7.51.3 aaronch12Ch/ultimo2
[Snyk] Upgrade react-hook-form from 7.34.2 to 7.51.3 TegroTON/Crypto-Wallet-Website
[Snyk] Upgrade react-hook-form from 7.43.9 to 7.51.3 fer-rouco/confiar
[Snyk] Upgrade react-hook-form from 7.48.2 to 7.51.3 Niraj-Dilshan/infinity
[Snyk] Upgrade react-hook-form from 7.16.2 to 7.51.4 fer-rouco/ncr-challenge
[Snyk] Upgrade react-hook-form from 7.34.2 to 7.51.4 TegroTON/Crypto-Wallet-Website
[Snyk] Upgrade react-hook-form from 7.48.2 to 7.51.4 Niraj-Dilshan/infinity
[Snyk] Upgrade react-hook-form from 7.27.1 to 7.51.4 peterleiva/community-client
[Snyk] Upgrade react-hook-form from 7.16.2 to 7.51.5 fer-rouco/ncr-challenge
1 participant
@geeee