feat(create-slider-with-tooltip): add get container method #615
Conversation
* follow the issue react-component#598 * add the possibility to add a get container method to fix the relative parent of the slider's tooltip
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
======================================
Coverage 95.4% 95.4%
======================================
Files 2 2
Lines 87 87
Branches 29 29
======================================
Hits 83 83
Misses 4 4Continue to review full report at Codecov.
|
|
Could you help to add an test case on this? |
|
yeah of course, I can try :) |
|
I try something but the thing is I don't know how tot test the use case where the tooltip is specially attach to a special node ancestor ... |
|
not sure about this test ... have try something with |
|
Seems file prettiered with other style. Please help to clean back. |
| }; | ||
| static defaultProps = { | ||
| tipFormatter(value) { return value; }, | ||
| handleStyle: [{}], | ||
| tipProps: {}, | ||
| getTooltipContainer: node => node.parentNode, |
There was a problem hiding this comment.
Can we revert https://github.com/ant-design/ant-design/pull/20699/files in favor of this PR?
There was a problem hiding this comment.
We'd better not since use getTooltipContainer will beak overflow hidden. #20699 is aim to compatible with origin behavior
#598