update react refs to use callback instead of strings #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move saveRef to utils and use anywhere we want to save a ref;
|
This is a vital PR that unblocks devs that are using React 16, along with react-component/calendar#282 and react-component/trigger#63 @afc163 can we please get these merged asap? |
This was referenced Jul 26, 2017
firstActiveValue
|
Hello @coderpawz, could you rebase master, then i will merge this. |
move saveRef to utils and use anywhere we want to save a ref;
fix conflict in DropdownMenu
|
hi @yesmeck, all done, thanks! |
|
@yesmeck @coderpawz It seems this got out of sync with master again after it was rebased last time. Can one of you pls rebase and merge when you have a chance? |
|
Need to rebase again.. |
|
@coderpawz can you please rebase when you have a chance? Need this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of React v16 using strings to create refs will no longer work. This is is forward looking change to address future compatibility issues as well as fixing existing deprecation warning thrown by react v15.
For consistency, also moved saveRef from Select.jsx to utils.js
For more info on refs, see https://facebook.github.io/react/docs/refs-and-the-dom.html