Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: customizable Option[title] #130

Merged
merged 1 commit into from
Nov 11, 2016
Merged

feat: customizable Option[title] #130

merged 1 commit into from
Nov 11, 2016

Conversation

benjycui
Copy link
Member

@benjycui benjycui commented Nov 8, 2016

Close: ant-design/ant-design#3063

允许用户自定义 title。

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 76.495% when pulling 01e0872 on feat-option-title into d6f1664 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 78.67% when pulling 12c3b19 on feat-option-title into d6f1664 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 78.817% when pulling af6597f on feat-option-title into 68250f8 on master.

@benjycui
Copy link
Member Author

benjycui commented Nov 8, 2016

Updated.

@afc163 afc163 merged commit df690e6 into master Nov 11, 2016
@afc163 afc163 deleted the feat-option-title branch November 11, 2016 11:47
@yiminghe
Copy link
Member

另外要补充个测试

@benjycui
Copy link
Member Author

title 不支持 JSX，因为这个值会直接设置到原生标签上。

@benjycui
Copy link
Member Author

测试等这个吧。。 #136

还是 Snapshot 比较方便。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yiminghe yiminghe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benjycui @coveralls @yiminghe @afc163