fix: add root element for SingleSelector to make layout easier #1076

guoyunhe · 2024-10-11T09:02:36Z

经过试验在 Ant Design 调整 prefix 的布局十分困难，因此需要在 SingleSelector 增加一个 wrapper 元素，来限制布局。

Summary by CodeRabbit

新功能
- 引入了新的搜索输入样式，移除了边框并应用半透明红色背景。
- 增强了下拉菜单的动画效果，包括滑入和滑出状态的平滑过渡。
样式更新
- 更新了多个选择器和单个选择器的样式，以改善组件的布局和外观。

vercel · 2024-10-11T09:02:41Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
select	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 15, 2024 6:01am

codecov · 2024-10-11T09:04:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (fb2a981) to head (add12a0).
Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1076   +/-   ##
=======================================
  Coverage   98.23%   98.24%           
=======================================
  Files          39       39           
  Lines        1474     1482    +8     
  Branches      439      446    +7     
=======================================
+ Hits         1448     1456    +8     
  Misses         26       26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Selector/SingleSelector.tsx

afc163 · 2024-10-12T06:05:41Z

src/Selector/SingleSelector.tsx

@@ -77,7 +77,7 @@ const SingleSelector: React.FC<SelectorProps> = (props) => {
  }, [item, hasTextInput, placeholder, prefixCls]);

  return (
-    <>
+    <span className={`${prefixCls}-selection-wrap`}>


Suggested change





不需要加 wrap

~~placeholder 特殊标记使用：classNames(xx-selection, xxx-selection-placeholder)~~

看起来是额外多一层？结构保持一致把，Single 和 Multiple 要加就一起加了：
https://github.com/react-component/select/blob/master/src/Selector/SingleSelector.tsx#L80
https://github.com/react-component/select/blob/master/src/Selector/MultipleSelector.tsx#L245

coderabbitai · 2024-10-15T06:00:13Z

Walkthrough

此次变更涉及对与 rc-select 功能相关的样式和组件进行多项修改。在 assets/index.less 中，新增了 .search-input-without-border 类以去除搜索输入框的边框，并应用半透明红色背景。同时，更新了 .rc-select-single 和 .rc-select-multiple 类以调整其内部结构和样式。此外，增加了下拉菜单的动画效果，增强了用户体验。在 src/Selector/MultipleSelector.tsx 和 src/Selector/SingleSelector.tsx 中，外层 JSX 片段被替换为  元素，以影响组件的样式和布局。

Changes

文件路径	变更摘要
assets/index.less	新增类 `.search-input-without-border`；新增嵌套类 `.rc-select-selection-wrap`；更新 `.rc-select-selection-search-input` 的样式；更新动画关键帧。
src/Selector/MultipleSelector.tsx, src/Selector/SingleSelector.tsx	外层 JSX 片段替换为 `<span>` 元素。

Suggested reviewers

zombieJ

Poem

在田野间，我跳跃欢快，
新样式如花，绽放无碍。
组件更新，布局新奇，
小兔子乐，舞动不息！ 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e08455c and add12a0.

⛔ Files ignored due to path filters (5)

tests/__snapshots__/Combobox.test.tsx.snap is excluded by !**/*.snap
tests/__snapshots__/Multiple.test.tsx.snap is excluded by !**/*.snap
tests/__snapshots__/Select.test.tsx.snap is excluded by !**/*.snap
tests/__snapshots__/Tags.test.tsx.snap is excluded by !**/*.snap
tests/__snapshots__/ssr.test.tsx.snap is excluded by !**/*.snap

📒 Files selected for processing (3)

assets/index.less (1 hunks)
src/Selector/MultipleSelector.tsx (1 hunks)
src/Selector/SingleSelector.tsx (2 hunks)

✅ Files skipped from review due to trivial changes (1)

src/Selector/MultipleSelector.tsx

🧰 Additional context used

🔇 Additional comments (3)

src/Selector/SingleSelector.tsx (1)
80-80: 🛠️ Refactor suggestion

考虑调整类名以保持一致性

添加包装元素的变更符合PR的目标，有助于简化布局调整。然而，有以下几点建议：

根据之前的评论，考虑将类名从 ${prefixCls}-selection-wrap 更改为 ${prefixCls}-selection。

确保 SingleSelector 和 MultipleSelector 组件的结构保持一致。如果在这里添加了额外的包装层，可能需要在 MultipleSelector 中也进行相应的修改。

建议应用以下更改：
- 
+ 
请运行以下脚本来验证 SingleSelector 和 MultipleSelector 的一致性：

Also applies to: 124-124
assets/index.less (2)

Line range hint 1-477: 文件变更总结

这个 LESS 文件的变更聚焦于改善单选择器的布局控制，通过添加新的 .rc-select-selection-wrap 类实现。这个改动与 PR 的目标一致，即通过添加包装元素使布局更容易调整。

整体而言，变更是最小化和集中的，这有利于维护性并降低了产生意外副作用的风险。然而，为确保变更的有效性和一致性，建议：

在相关的 React 组件文件中验证新增包装元素的使用情况。

考虑更新组件文档，反映这一新的布局结构。

如果有单元测试或集成测试，确保更新它们以覆盖这一变更。

73-77: 新增的包装元素有助于布局控制

新增的 .rc-select-selection-wrap 类为单选择器提供了额外的布局控制。这与 PR 的目标一致，即通过添加包装元素使布局更容易调整。

建议：

考虑为这个新的包装元素添加注释，解释其用途和重要性。

确保在相应的 React 组件中正确使用了这个新的包装元素。

请运行以下脚本来验证新增的包装元素在 React 组件中的使用：

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vercel bot deployed to Preview October 11, 2024 09:03 View deployment

zombieJ reviewed Oct 11, 2024

View reviewed changes

src/Selector/SingleSelector.tsx Outdated Show resolved Hide resolved

guoyunhe force-pushed the single-selector-root branch from 046105b to 4b55511 Compare October 12, 2024 03:57

vercel bot deployed to Preview October 12, 2024 03:57 View deployment

afc163 reviewed Oct 12, 2024

View reviewed changes

fix: add root element for SingleSelector to make layout easier

add12a0

guoyunhe force-pushed the single-selector-root branch from 4b55511 to add12a0 Compare October 15, 2024 06:00

vercel bot deployed to Preview October 15, 2024 06:01 View deployment

zombieJ approved these changes Oct 15, 2024

View reviewed changes

zombieJ merged commit a285745 into react-component:master Oct 15, 2024
11 checks passed

coderabbitai bot mentioned this pull request Oct 15, 2024

fix: placeholder #1079

Merged

afc163 mentioned this pull request Oct 16, 2024

chore: upgrade rc-tree and rc-tree-select and rc-cascader ant-design/ant-design#51251

Merged

16 tasks

coderabbitai bot mentioned this pull request Nov 2, 2024

feat: support overriding default component behavior for the onBlur event in tags mode #1081

Open

fianbong2014 mentioned this pull request Nov 7, 2024

[Snyk] Upgrade rc-select from 14.5.2 to 14.16.2 fianbong2014/ant-design#2

Open

coderabbitai bot mentioned this pull request Nov 11, 2024

fix: https://github.com/ant-design/ant-design/issues/50642 #1084

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add root element for SingleSelector to make layout easier #1076

fix: add root element for SingleSelector to make layout easier #1076

guoyunhe commented Oct 11, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Oct 11, 2024 •

edited

Loading

codecov bot commented Oct 11, 2024 •

edited

Loading

afc163 Oct 12, 2024

zombieJ Oct 14, 2024 •

edited

Loading

coderabbitai bot commented Oct 15, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

	<span className={`${prefixCls}-selection-wrap`}>
	<span className={`${prefixCls}-selection`}>

fix: add root element for SingleSelector to make layout easier #1076

fix: add root element for SingleSelector to make layout easier #1076

Conversation

guoyunhe commented Oct 11, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

vercel bot commented Oct 11, 2024 • edited Loading

codecov bot commented Oct 11, 2024 • edited Loading

Codecov Report

afc163 Oct 12, 2024

Choose a reason for hiding this comment

zombieJ Oct 14, 2024 • edited Loading

Choose a reason for hiding this comment

coderabbitai bot commented Oct 15, 2024 • edited Loading

Walkthrough

Changes

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

guoyunhe commented Oct 11, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Oct 11, 2024 •

edited

Loading

codecov bot commented Oct 11, 2024 •

edited

Loading

zombieJ Oct 14, 2024 •

edited

Loading

coderabbitai bot commented Oct 15, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)