refactor: changeOnWheel #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #619 +/- ##
=======================================
Coverage 94.53% 94.53%
=======================================
Files 6 6
Lines 293 293
Branches 74 75 +1
=======================================
Hits 277 277
Misses 16 16 ☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Jan 24, 2024
| @@ -118,7 +118,7 @@ const InternalInputNumber = React.forwardRef( | |||
| upHandler, | |||
| downHandler, | |||
| keyboard, | |||
| wheel, | |||
| changeOnWheel = false, | |||
There was a problem hiding this comment.
可不可以先开启，然后有问题反馈再关闭呢？focus + hover 感觉已经是非常约束的条件了。
There was a problem hiding this comment.
老属性删掉属于 breaking change，需要发 major。
20 tasks
zombieJ
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wheel重命名为changeOnWheel并且在 focus 状态才可以触发