Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: defaultValue wrongly overrode value (antd#30873) #335

Merged
merged 1 commit into from
Jun 6, 2021
Merged

fix: defaultValue wrongly overrode value (antd#30873) #335

merged 1 commit into from
Jun 6, 2021

Conversation

neotan
Copy link
Contributor

@neotan neotan commented Jun 5, 2021

To fix antd#30873. Sync-ed behaviour with Input component

@vercel
Copy link

vercel bot commented Jun 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/input-number/DCdg6s5wgEuwug9KC9Sf61FwFNJ2
✅ Preview: https://input-number-git-fork-neotan-fix-defaultvalue-overrode-d7980d.vercel.app

Copy link

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 6, 2021

Codecov Report

Merging #335 (d7ae508) into master (8482dda) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #335   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files           8        8           
  Lines         411      411           
  Branches      109      109           
=======================================
  Hits          401      401           
  Misses         10       10           
Impacted Files Coverage Δ
src/InputNumber.tsx 98.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8482dda...d7ae508. Read the comment docs.

@zombieJ zombieJ merged commit f92593a into react-component:master Jun 6, 2021
@zombieJ
Copy link
Member

zombieJ commented Jun 6, 2021

+ [email protected]

@neotan neotan deleted the fix/defaultValue-overrode-value branch June 6, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[InputNumber] defaultValue overrided value property
3 participants