-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support max length #313
Changes from 1 commit
373b294
3afcbfb
7f479e1
971b777
7e5c598
aa6cea0
76d2bf8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -67,6 +67,7 @@ export interface InputNumberProps<T extends ValueType = ValueType> | |||||
// useTouch: boolean; | ||||||
|
||||||
// size?: ISize; | ||||||
maxLength?: number; | ||||||
} | ||||||
|
||||||
const InputNumber = React.forwardRef( | ||||||
|
@@ -92,6 +93,7 @@ const InputNumber = React.forwardRef( | |||||
formatter, | ||||||
precision, | ||||||
decimalSeparator, | ||||||
maxLength, | ||||||
|
||||||
onChange, | ||||||
onInput, | ||||||
|
@@ -336,8 +338,11 @@ const InputNumber = React.forwardRef( | |||||
}; | ||||||
|
||||||
// >>> Input | ||||||
const onInternalInput: React.ChangeEventHandler<HTMLInputElement> = (e) => { | ||||||
const onInternalInput: React.ChangeEventHandler<HTMLInputElement> = e => { | ||||||
let inputStr = e.target.value; | ||||||
if (maxLength) { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
这样会不会好些? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 不太对哦,是不是 大于0 就行了 等于 没有任何意义吧 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
主要目的是为了判断为数字 |
||||||
inputStr = inputStr.slice(0, maxLength); | ||||||
} | ||||||
|
||||||
// optimize for chinese input experience | ||||||
// https://github.com/ant-design/ant-design/issues/8196 | ||||||
|
@@ -404,7 +409,7 @@ const InputNumber = React.forwardRef( | |||||
} | ||||||
}; | ||||||
|
||||||
const onKeyDown: React.KeyboardEventHandler<HTMLInputElement> = (event) => { | ||||||
const onKeyDown: React.KeyboardEventHandler<HTMLInputElement> = event => { | ||||||
const { which } = event; | ||||||
userTypingRef.current = true; | ||||||
|
||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
来个测试用例哈~