Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recover deleted code #64

Merged
merged 2 commits into from
Jan 22, 2021
Merged

fix: recover deleted code #64

merged 2 commits into from
Jan 22, 2021

Conversation

shaodahong
Copy link
Member

@vercel
Copy link

vercel bot commented Jan 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/image/7o7n02k5o
✅ Preview: https://image-git-fix-antd-28953.react-component.vercel.app

act(() => {
wrapper.setProps({});
jest.runAllTimers();
wrapper.update();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当时就很奇怪这块的测试是干啥的

https://github.com/react-component/image/pull/48/files

果然天网恢恢啊

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #64 (9f95e9f) into master (973e5ad) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #64   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          230       233    +3     
  Branches        63        65    +2     
=========================================
+ Hits           230       233    +3     
Impacted Files Coverage Δ
src/Image.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 973e5ad...9f95e9f. Read the comment docs.

@shaodahong shaodahong requested review from afc163 and zombieJ January 21, 2021 02:38
@shaodahong shaodahong merged commit e745b28 into master Jan 22, 2021
@shaodahong shaodahong deleted the fix-antd-28953 branch January 22, 2021 09:54
@u3u
Copy link
Contributor

u3u commented Jan 25, 2021

啊 我当时发现这一块代码没了 还以为是特意删除的
那这样的话 #45 这个问题是不是又会复现了

@shaodahong
Copy link
Member Author

啊 我当时发现这一块代码没了 还以为是特意删除的
那这样的话 #45 这个问题是不是又会复现了

应该是,所以要把判断条件抽出去判断下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Placeholder doesn't show after updating Ant Design from 4.9.x to 4.10.x
2 participants