Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support onChange when current change #141

Merged
merged 8 commits into from
Jan 20, 2023
Merged

feat: support onChange when current change #141

merged 8 commits into from
Jan 20, 2023

Conversation

kiner-tang
Copy link
Contributor

@kiner-tang kiner-tang commented Nov 9, 2022 •
edited by MadCcc
Loading

@vercel
Copy link

vercel bot commented Nov 9, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
image ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 6:57AM (UTC)

@kiner-tang
Copy link
Contributor Author

Can someone review this 'pr' for me? @afc163

afc163
afc163 reviewed Nov 12, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 12, 2022 •
edited
Loading

Codecov Report

Merging #141 (ba89d6d) into master (c403700) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #141   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          304       312    +8     
  Branches        94        95    +1     
=========================================
+ Hits           304       312    +8
Impacted Files Coverage Δ
src/Preview.tsx 100.00% <ø> (ø)
src/PreviewGroup.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kiner-tang kiner-tang requested a review from afc163 November 12, 2022 13:39
@kiner-tang
Copy link
Contributor Author

@afc163 可以在review一下这个pr么

@afc163
Copy link
Member

afc163 commented Dec 27, 2022

@MadCcc @zombieJ 看看

@afc163 afc163 requested review from zombieJ and MadCcc December 27, 2022 10:38
MadCcc
MadCcc reviewed Jan 18, 2023
View reviewed changes
src/PreviewGroup.tsx Outdated Show resolved Hide resolved
@kiner-tang kiner-tang requested review from MadCcc and removed request for afc163 and zombieJ January 18, 2023 11:35
@MadCcc MadCcc merged commit 38ba334 into react-component:master Jan 20, 2023
@afc163 afc163 mentioned this pull request Feb 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

@MadCcc MadCcc Awaiting requested review from MadCcc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image组件的preview功能可以加个图片切换事件吗
3 participants
@kiner-tang @afc163 @MadCcc