-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dom-helpers #446
Upgrade dom-helpers #446
Conversation
might want to update RTG first, though, since we're still pulling in dom-helpers via RTG |
hmm, strange that the CI build didn't kick off. Is this branch up to date with the master branch? |
Yes, I pulled master before submmitting. |
I just ran the build locally, and it seems to be failing on this test with the following error:
|
f5d0fd6
to
8833780
Compare
@bpas247 Looks like it was race condition. |
yeah that happens occasionally when browser windows aren't actively focused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working as of 8833780 👍
8833780
to
d2aa1d9
Compare
I merged this to master. Will merge once CI goes green. |
okay... so the way we have the codecov secret set up means it's not accessible for builds from forks. bleh. |
Any easy fix for that? |
I don't see a way in the secret config to expose secrets to builds from forks. We might just have to wait until there's better first-party support here, and just deal with the pain for now. Not a problem in this case anyway because we don't care about coverage diffs for this change. |
This seems related to the overall issue of not allowing token-free uploads for public repos, so hopefully they'll push a fix for it soon. |
Ref react-bootstrap/dom-helpers@87e2fe4
/cc @jquense