Issue 2013 #2014
Merged
Issue 2013 #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appveyor failed because it use react 15.2.0, do I need to change the package.json in the PR ? |
|
Looks fine to me. |
| @@ -31,11 +40,13 @@ export default class DropdownToggle extends React.Component { | |||
| DropdownToggle.defaultProps = { | |||
| open: false, | |||
| useAnchor: false, | |||
| bsRole: 'toggle' | |||
| bsRole: 'toggle', | |||
| bsClass: 'dropdown' | |||
There was a problem hiding this comment.
for consistency this should be defined via the bsClass helper in bootstrapUtils, other than that looks good 👍
There was a problem hiding this comment.
I've actually been going through and swapping everything out for bsClass on my "update for React v15.2.0" branch.
|
LGTM, can't merge from my phone tho |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2013