-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add individual CarouselItem intervals #5305
Comments
oof that is not straight forward :/ |
So if I'm understanding the feature correctly, the API would look something like <Carousel>
<Carousel.Item interval={10000}>
<img
className="d-block w-100"
src="holder.js/800x400?text=First slide&bg=373940"
alt="First slide"
/>
<Carousel.Caption>
<h3>First slide label</h3>
<p>Nulla vitae elit libero, a pharetra augue mollis interdum.</p>
</Carousel.Caption>
</Carousel.Item>
<Carousel.Item interval={2000}>
<img
className="d-block w-100"
src="holder.js/800x400?text=Second slide&bg=282c34"
alt="Second slide"
/>
<Carousel.Caption>
<h3>Second slide label</h3>
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit.</p>
</Carousel.Caption>
</Carousel.Item>
</Carousel> A couple questions regarding this:
|
In the bootstrap example, it looks like the children intervals take precedence, and in the absence of a child interval, the |
Child interval values might not be too bad... we need to iterate through the children to count them anyway, so why not also grab their intervals when we do so? |
Yep, that's the current plan I'm going with 👍 just need to get it working lol |
Adds the ability to specify intervals per-item, which should hopefully match the functionality of the upstream feature. TODOs: - [ ] Add prop types for the `interval` prop for `CarouselItem` fixes #5305
Adds the ability to specify intervals per-item, which should hopefully match the functionality of the upstream feature. TODOs: - [ ] Add prop types for the `interval` prop for `CarouselItem` fixes #5305
Adds the ability to specify intervals per-item, which should hopefully match the functionality of the upstream feature. TODOs: - [ ] Add prop types for the `interval` prop for `CarouselItem` fixes #5305
Adds the ability to specify intervals per-item, which should hopefully match the functionality of the upstream feature. TODOs: - [ ] Add prop types for the `interval` prop for `CarouselItem` fixes #5305
Adds the ability to specify intervals per-item, which should hopefully match the functionality of the upstream feature. TODOs: - [ ] Add prop types for the `interval` prop for `CarouselItem` fixes #5305
Adds the ability to specify intervals per-item, which should hopefully match the functionality of the upstream feature. fixes #5305
https://getbootstrap.com/docs/4.5/components/carousel/#individual-carousel-item-interval
The text was updated successfully, but these errors were encountered: