-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs behavior when activeKey is null #1227
Comments
I tend to prefer letting |
Oh, we should just use uncontrollable here. But as a quick patch, seems like we should make that check be this.props.activeKey !== undefined then. |
We currently treat
null
andundefined
identically for deciding whether aTabs
component is controlled: https://github.com/react-bootstrap/react-bootstrap/blob/v0.25.0/src/Tabs.js#L196Is this what we want, or should we interpret
null
as "controlled, but nothing selected"?The text was updated successfully, but these errors were encountered: