Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update react to 17.0.0 and prepare for CRAN #51

Merged
merged 14 commits into from
Feb 22, 2021
Merged

Conversation

timelyportfolio
Copy link
Collaborator

No description provided.

@timelyportfolio
Copy link
Collaborator Author

@stla @DivadNojnarg @swsoyee @glin I would really appreciate if you have some time to test this newest version before I submit to CRAN. All JS and R tests pass, but now that this is a package with reverse dependencies and modest popularity I feel a greater responsibility to make sure nothing breaks. The primary changes are with widget to comply with new htmlwidgets convention #49, template clean up #45, webpack + style/css-loader #50, and React -> 17.0.0.

@glin
Copy link
Contributor

glin commented Feb 21, 2021

@timelyportfolio This works fine with reactable, thanks for the heads up.

@timelyportfolio timelyportfolio merged commit 7dccb68 into master Feb 22, 2021
@stla
Copy link
Contributor

stla commented May 25, 2021

Hi @timelyportfolio

I have tested the shinyInput with this new version, it works fine.

@timelyportfolio
Copy link
Collaborator Author

thanks @stla. Hope to work on a new update over the next couple of weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants