Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally in React this would be not be considered best practice but in the case of Shiny we know that element is stable across a session.
Also, many of the npm dependencies are out-of-date, so potentially at the risk of confusing this with that, went ahead and upgraded all npm dependencies. JS tests all passed.
https://github.com/react-R/reactvega/blob/master/srcjs/reactvega.jsx is an example usage of new functionality that allows us to add the
el
id to our Shiny input value for the purpose of referencing in Shiny withobserve/observeEvent
. I don't think there is any other way to accomplish otherwise.