Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, added another example with tooltips rendering inside a modal to try to replicate more closely the bug described by @bvaughn in #193.
Note: It was suggested in #193 that the bug was in the auto-id package since it provides
null
ids on the initial render. According to @ryanflorence this behavior is intentional. auto-id is not supposed to provide ids on the initial render because of the non-deterministic nature of server-rendered apps. Instead, they are supposed to be applied only after the initial render, to be used by screen readers.Fixes #193
Closes #293
Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.
yarn test
).yarn start
).This pull request: