Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltips flicker #319

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Fix tooltips flicker #319

merged 1 commit into from
Oct 18, 2019

Conversation

mjackson
Copy link
Member

Also, added another example with tooltips rendering inside a modal to try to replicate more closely the bug described by @bvaughn in #193.

Note: It was suggested in #193 that the bug was in the auto-id package since it provides null ids on the initial render. According to @ryanflorence this behavior is intentional. auto-id is not supposed to provide ids on the initial render because of the non-deterministic nature of server-rendered apps. Instead, they are supposed to be applied only after the initial render, to be used by screen readers.

Fixes #193
Closes #293

Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code (Compile and run).
  • Add or edit tests to reflect the change (Run with yarn test).
  • Add or edit Storybook examples to reflect the change (Run with yarn start).
  • Ensure formatting is consistent with the project's Prettier configuration.

This pull request:

  • Creates a new package
  • Fixes a bug in an existing package
  • Adds additional features/functionality to an existing package
  • Updates documentation or example code
  • Other

Also, added another example with tooltips rendering inside a modal to
try to replicate more closely the bug described by @bvaughn in #193.

Fixes #193
Closes #293
@mjackson mjackson added the Type: Bug Something isn't working label Oct 18, 2019
@mjackson mjackson requested a review from chaance October 18, 2019 03:40
@mjackson mjackson mentioned this pull request Oct 18, 2019
16 tasks
@chaance
Copy link
Member

chaance commented Oct 18, 2019

Looks good to me 👍

@chaance chaance merged commit 4ed36bf into master Oct 18, 2019
@chaance chaance deleted the fix-tooltips-flicker branch October 23, 2019 16:37
chaance pushed a commit that referenced this pull request Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltips flicker when modal dialog is added
2 participants