Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Slider + Dialog propType declarations in prod #306

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

mjackson
Copy link
Member

Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code (Compile and run).
  • Add or edit tests to reflect the change (Run with yarn test).
  • Add or edit Storybook examples to reflect the change (Run with yarn start).
  • Ensure formatting is consistent with the project's Prettier configuration.

This pull request:

  • Creates a new package
  • Fixes a bug in an existing package
  • Adds additional features/functionality to an existing package
  • Updates documentation or example code
  • Other

@mjackson
Copy link
Member Author

@chancestrickland We can use the special __DEV__ flag to indicate pieces of code that should only run in development. Our shared babel config uses a plugin that will set the value of this variable depending on whether we are building for dev or prod.

@mjackson mjackson force-pushed the exclude-slider-proptypes branch from 955de4d to 588b4d6 Compare October 14, 2019 21:04
@mjackson mjackson changed the title Exclude Slider propType declarations in prod Exclude Slider + Dialog propType declarations in prod Oct 14, 2019
@chaance chaance merged commit e5b9bb9 into master Oct 14, 2019
@chaance chaance added the Type: Enhancement General improvements or suggestions label Oct 14, 2019
@mjackson mjackson deleted the exclude-slider-proptypes branch October 14, 2019 21:47
chaance pushed a commit that referenced this pull request Oct 23, 2019
Exclude Slider + Dialog propType declarations in prod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement General improvements or suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants