Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab buttons need type='button' #165

Closed
flybayer opened this issue May 6, 2019 · 4 comments · Fixed by #572
Closed

Tab buttons need type='button' #165

flybayer opened this issue May 6, 2019 · 4 comments · Fixed by #572
Labels
Status: Unconfirmed Bug reports without a repro, not yet confirmed Type: Enhancement General improvements or suggestions

Comments

@flybayer
Copy link

flybayer commented May 6, 2019

I'm launching the Dialog from inside a form. The default tab buttons have the default, implicit type of "submit" so clicking a tab submits the form.

Workaround is manually set type='button' on each <Tab>
@olistic
Copy link

olistic commented May 7, 2019

I just run into this issue. Happy to submit a PR for this, just lemme know!

@bradwestfall bradwestfall added Type: Enhancement General improvements or suggestions Status: Unconfirmed Bug reports without a repro, not yet confirmed labels Oct 1, 2019
chaance added a commit that referenced this issue Oct 14, 2019
@chaance
Add type="button" for tabs by default (#165)
195c6a6
@chaance
Copy link
Member

chaance commented Oct 14, 2019

Fixed in #304

@chaance chaance closed this as completed Oct 14, 2019
chaance added a commit that referenced this issue Oct 23, 2019
@chaance
Add type="button" for tabs by default (#165)
5f75dd5
@1000hz
Copy link

1000hz commented Apr 29, 2020 •
edited
Loading

this seems to have regressed in a2ab2be (v0.7.3)

@chaance chaance reopened this Apr 29, 2020
@rubenmoya rubenmoya mentioned this issue May 3, 2020
Merged
15 tasks
@chaance
Copy link
Member

chaance commented May 4, 2020

Per my note in the linked PR, this was removed because our type check isn't reliable. It might still be worth it to have this as a default, but if a custom component is passed to as then the end user will still have to manually set type="button" if a button element is ultimately created.

@snyk-bot snyk-bot mentioned this issue Jan 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Unconfirmed Bug reports without a repro, not yet confirmed Type: Enhancement General improvements or suggestions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use type button by default in Tab component
5 participants
@1000hz @bradwestfall @chaance @olistic @flybayer