Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop and rubocop-rspec #2497

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 7, 2023

Bumps rubocop and rubocop-rspec. These dependencies needed to be updated together.
Updates rubocop from 0.93.1 to 1.58.0

Release notes

Sourced from rubocop's releases.

RuboCop 1.58

New features

Bug fixes

  • #12372: Fix a false negative for Lint/Debugger when used within method arguments a begin...end block. (@​koic)
  • #12378: Fix a false negative for Style/Semicolon when a semicolon at the beginning of a lambda block. (@​koic)
  • #12146: Fix a false positive for Lint/FloatComparison when comparing against zero. (@​earlopain)
  • #12404: Fix a false positive for Layout/RescueEnsureAlignment when aligned rescue in do-end numbered block in a method. (@​koic)
  • #12374: Fix a false positive for Layout/SpaceBeforeSemicolon when a space between an opening lambda brace and a semicolon. (@​koic)
  • #12326: Fix an error for Style/RedundantDoubleSplatHashBraces when method call for parenthesized no hash double double splat. (@​koic)
  • #12361: Fix an incorrect autocorrect for Naming/BlockForwarding and Style/ArgumentsForwarding when autocorrection conflicts for anonymous arguments. (@​koic)
  • #12324: Fix an error for Layout/RescueEnsureAlignment when using rescue in do...end block assigned to object attribute. (@​koic)
  • #12322: Fix an error for Style/CombinableLoops when looping over the same data for the third consecutive time or more. (@​koic)
  • #12366: Fix a false negative for Layout/ExtraSpacing when a file has exactly two comments. (@​eugeneius)
  • #12373: Fix a false negative for Lint/SymbolConversion when using string interpolation. (@​earlopain)
  • #12402: Fix false negatives for Style/RedundantLineContinuation when redundant line continuations for a block are used, especially without parentheses around first argument. (@​koic)
  • #12311: Fix false negatives for Style/RedundantParentheses when parentheses around logical operator keywords in method definition. (@​koic)
  • #12394: Fix false negatives for Style/RedundantReturn when lambda (->) ending with return. (@​koic)
  • #12377: Fix false positives for Lint/Void when a collection literal that includes non-literal elements in a method definition. (@​koic)
  • #12407: Fix an incorrect autocorrect for Style/MapToHash with Layout/SingleLineBlockChain. (@​koic)
  • #12409: Fix an incorrect autocorrect for Lint/SafeNavigationChain when ordinary method chain exists after safe navigation leading dot method call. (@​koic)
  • #12363: Fix incorrect rendering of HTML character entities in HTMLFormatter formatter. (@​koic)
  • #12424: Make Style/HashEachMethods aware of safe navigation operator. (@​koic)
  • #12413: Make Style/InverseMethods aware of safe navigation operator. (@​koic)
  • #12408: Make Style/MapToHash aware of safe navigation operator. (@​koic)

Changes

  • #12328: Make Style/AutoResourceCleanup aware of Tempfile.open. (@​koic)
  • #12412: Enhance Lint/RedundantSafeNavigation to handle conversion methods with defaults. (@​fatkodima)
  • #12410: Enhance Lint/SelfAssignment to check attribute assignment and key assignment. (@​fatkodima)
  • #12370: Make Style/HashEachMethods aware of unused block value. (@​koic)
  • #12380: Make Style/RedundantParentheses aware of lambda or proc. (@​koic)
  • #12421: Make Style/SelfAssignment aware of %, ^, <<, and >> operators. (@​koic)
  • #12305: Require rubocop-ast version 1.30 or greater. (@​sambostock)
  • #12337: Supports EnforcedStyleForRationalLiterals option for Layout/SpaceAroundOperators. (@​koic)
  • #12296: Support RedundantRestArgumentNames, RedundantKeywordRestArgumentNames, and RedundantBlockArgumentNames options for Style/ArgumentsForwarding. (@​koic)

RuboCop 1.57.2

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.58.0 (2023-12-01)

New features

Bug fixes

  • #12372: Fix a false negative for Lint/Debugger when used within method arguments a begin...end block. ([@​koic][])
  • #12378: Fix a false negative for Style/Semicolon when a semicolon at the beginning of a lambda block. ([@​koic][])
  • #12146: Fix a false positive for Lint/FloatComparison when comparing against zero. ([@​earlopain][])
  • #12404: Fix a false positive for Layout/RescueEnsureAlignment when aligned rescue in do-end numbered block in a method. ([@​koic][])
  • #12374: Fix a false positive for Layout/SpaceBeforeSemicolon when a space between an opening lambda brace and a semicolon. ([@​koic][])
  • #12326: Fix an error for Style/RedundantDoubleSplatHashBraces when method call for parenthesized no hash double double splat. ([@​koic][])
  • #12361: Fix an incorrect autocorrect for Naming/BlockForwarding and Style/ArgumentsForwarding when autocorrection conflicts for anonymous arguments. ([@​koic][])
  • #12324: Fix an error for Layout/RescueEnsureAlignment when using rescue in do...end block assigned to object attribute. ([@​koic][])
  • #12322: Fix an error for Style/CombinableLoops when looping over the same data for the third consecutive time or more. ([@​koic][])
  • #12366: Fix a false negative for Layout/ExtraSpacing when a file has exactly two comments. ([@​eugeneius][])
  • #12373: Fix a false negative for Lint/SymbolConversion when using string interpolation. ([@​earlopain][])
  • #12402: Fix false negatives for Style/RedundantLineContinuation when redundant line continuations for a block are used, especially without parentheses around first argument. ([@​koic][])
  • #12311: Fix false negatives for Style/RedundantParentheses when parentheses around logical operator keywords in method definition. ([@​koic][])
  • #12394: Fix false negatives for Style/RedundantReturn when lambda (->) ending with return. ([@​koic][])
  • #12377: Fix false positives for Lint/Void when a collection literal that includes non-literal elements in a method definition. ([@​koic][])
  • #12407: Fix an incorrect autocorrect for Style/MapToHash with Layout/SingleLineBlockChain. ([@​koic][])
  • #12409: Fix an incorrect autocorrect for Lint/SafeNavigationChain when ordinary method chain exists after safe navigation leading dot method call. ([@​koic][])
  • #12363: Fix incorrect rendering of HTML character entities in HTMLFormatter formatter. ([@​koic][])
  • #12424: Make Style/HashEachMethods aware of safe navigation operator. ([@​koic][])
  • #12413: Make Style/InverseMethods aware of safe navigation operator. ([@​koic][])
  • #12408: Make Style/MapToHash aware of safe navigation operator. ([@​koic][])

Changes

  • #12328: Make Style/AutoResourceCleanup aware of Tempfile.open. ([@​koic][])
  • #12412: Enhance Lint/RedundantSafeNavigation to handle conversion methods with defaults. ([@​fatkodima][])
  • #12410: Enhance Lint/SelfAssignment to check attribute assignment and key assignment. ([@​fatkodima][])
  • #12370: Make Style/HashEachMethods aware of unused block value. ([@​koic][])
  • #12380: Make Style/RedundantParentheses aware of lambda or proc. ([@​koic][])
  • #12421: Make Style/SelfAssignment aware of %, ^, <<, and >> operators. ([@​koic][])
  • #12305: Require rubocop-ast version 1.30 or greater. ([@​sambostock][])
  • #12337: Supports EnforcedStyleForRationalLiterals option for Layout/SpaceAroundOperators. ([@​koic][])
  • #12296: Support RedundantRestArgumentNames, RedundantKeywordRestArgumentNames, and RedundantBlockArgumentNames options for Style/ArgumentsForwarding. ([@​koic][])

1.57.2 (2023-10-26)

Bug fixes

  • #12274: Fix a false positive for Lint/Void when each's receiver is an object of Enumerator to which filter has been applied. ([@​koic][])
  • #12291: Fix a false positive for Metrics/ClassLength when a class with a singleton class definition. ([@​koic][])

... (truncated)

Commits
  • f27164b Cut 1.58
  • 73b0876 Update Changelog
  • 19daa1c Add new Lint/LiteralAssignmentInCondition cop
  • c8d2d77 [Fix #12424] Make Style/HashEachMethods aware of safe navigation operator
  • 3db23fa Merge pull request #12422 from fatkodima/optimize-tests
  • 7f0a589 Optimize rspec tests
  • 4753e92 Merge pull request #12421 from koic/make_style_self_assignment_aware_of_some_...
  • 2f9a2d2 Make Style/SelfAssignment aware of some operators
  • a31a37c Merge pull request #12387 from Earlopain/fix-zero-method-for-float-comparison
  • 7a66f24 [Fix #12146] Fix a false positive for Lint/FloatComparison
  • Additional commits viewable in compare view

Updates rubocop-rspec from 1.44.1 to 2.25.0

Release notes

Sourced from rubocop-rspec's releases.

RuboCop RSpec v2.25.0

  • Add support single quoted string and percent string and heredoc for RSpec/Rails/HttpStatus. (@​ydah)
  • Change to be inline disable for RSpec/SpecFilePathFormat like RSpec/FilePath. (@​ydah)
  • Fix a false positive for RSpec/MetadataStyle with example groups having multiple string arguments. (@​franzliedke)

RuboCop RSpec v2.24.1

  • Fix an error when using RSpec/FilePath and revert to enabled by default. If you have already moved to RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat, disable RSpec/FilePath explicitly as Enabled: false. The RSpec/FilePath before migration and the RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat as the target are available respectively. (@​ydah)

RuboCop RSpec v2.24.0

  • Split RSpec/FilePath into RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat. RSpec/FilePath cop is enabled by default, the two new cops are pending and need to be enabled explicitly. (@​ydah)
  • Add new RSpec/Eq cop. (@​ydah)
  • Add RSpec/MetadataStyle and RSpec/EmptyMetadata cops. (@​r7kamura)
  • Add support RSpec/Rails/HttpStatus when have_http_status with string argument. (@​ydah)
  • Fix an infinite loop error when RSpec/ExcessiveDocstringSpacing finds a description with non-ASCII leading/trailing whitespace. (@​bcgraham)
  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when return values declared between stubs. (@​marocchino)
  • Fix a false positive RSpec/Focus when chained method call and inside define method. (@​ydah)

RuboCop RSpec v2.23.2

  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when method is only non-word character. (@​marocchino)
  • Fix a false positive for RSpec/ReceiveMessages when return with splat. (@​marocchino)

RuboCop RSpec v2.23.1

  • Mark to Safe: false for RSpec/Rails/NegationBeValid cop. (@​ydah)
  • Declare autocorrect as unsafe for RSpec/ReceiveMessages. (@​bquorning)

RuboCop RSpec v2.23.0

  • Add new RSpec/Rails/NegationBeValid cop. (@​ydah)
  • Fix a false negative for RSpec/ExcessiveDocstringSpacing when finds description with em space. (@​ydah)
  • Fix a false positive for RSpec/EmptyExampleGroup when example group with examples defined in if branch inside iterator. (@​ydah)
  • Update the message output of RSpec/ExpectActual to include the word 'value'. ([@​corydiamand])
  • Fix a false negative for RSpec/Pending when it without body. (@​ydah)
  • Add new RSpec/ReceiveMessages cop. (@​ydah)
  • Change default.yml path to use **/spec/* instead of spec/*. (@​ydah)
  • Add AllowedIdentifiers and AllowedPatterns configuration option to RSpec/IndexedLet. (@​ydah)
  • Fix RSpec/NamedSubject when block has no body. ([@​splattael])

... (truncated)

Changelog

Sourced from rubocop-rspec's changelog.

2.25.0 (2023-10-27)

  • Add support single quoted string and percent string and heredoc for RSpec/Rails/HttpStatus. ([@​ydah])
  • Change to be inline disable for RSpec/SpecFilePathFormat like RSpec/FilePath. ([@​ydah])
  • Fix a false positive for RSpec/MetadataStyle with example groups having multiple string arguments. ([@​franzliedke])

2.24.1 (2023-09-23)

  • Fix an error when using RSpec/FilePath and revert to enabled by default. If you have already moved to RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat, disable RSpec/FilePath explicitly as Enabled: false. The RSpec/FilePath before migration and the RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat as the target are available respectively. ([@​ydah])

2.24.0 (2023-09-08)

  • Split RSpec/FilePath into RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat. RSpec/FilePath cop is disabled by default and the two new cops are pending and need to be enabled explicitly. ([@​ydah])
  • Add new RSpec/Eq cop. ([@​ydah])
  • Add RSpec/MetadataStyle and RSpec/EmptyMetadata cops. ([@​r7kamura])
  • Add support RSpec/Rails/HttpStatus when have_http_status with string argument. ([@​ydah])
  • Fix an infinite loop error when RSpec/ExcessiveDocstringSpacing finds a description with non-ASCII leading/trailing whitespace. ([@​bcgraham])
  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when return values declared between stubs. ([@​marocchino])
  • Fix a false positive RSpec/Focus when chained method call and inside define method. ([@​ydah])

2.23.2 (2023-08-09)

  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when method is only non-word character. ([@​marocchino])
  • Fix a false positive for RSpec/ReceiveMessages when return with splat. ([@​marocchino])

2.23.1 (2023-08-07)

  • Mark to Safe: false for RSpec/Rails/NegationBeValid cop. ([@​ydah])
  • Declare autocorrect as unsafe for RSpec/ReceiveMessages. ([@​bquorning])

2.23.0 (2023-07-30)

  • Add new RSpec/Rails/NegationBeValid cop. ([@​ydah])
  • Fix a false negative for RSpec/ExcessiveDocstringSpacing when finds description with em space. ([@​ydah])
  • Fix a false positive for RSpec/EmptyExampleGroup when example group with examples defined in if branch inside iterator. ([@​ydah])
  • Update the message output of RSpec/ExpectActual to include the word 'value'. ([@​corydiamand])
  • Fix a false negative for RSpec/Pending when it without body. ([@​ydah])
  • Add new RSpec/ReceiveMessages cop. ([@​ydah])
  • Change default.yml path to use **/spec/* instead of spec/*. ([@​ydah])
  • Add AllowedIdentifiers and AllowedPatterns configuration option to RSpec/IndexedLet. ([@​ydah])
  • Fix RSpec/NamedSubject when block has no body. ([@​splattael])
  • Fix RSpec/LetBeforeExamples autocorrect incompatible with RSpec/ScatteredLet autocorrect. ([@​ydah])
  • Update RSpec/Focus to support shared_context and shared_examples. ([@​tmaier])

2.22.0 (2023-05-06)

  • Extract factory_bot cops to a separate repository, rubocop-factory_bot. The rubocop-factory_bot repository is a dependency of rubocop-rspec and the factory_bot cops are aliased (RSpec/FactoryBot/Foo == FactoryBot/Foo) until v3.0 is released, so the change will be invisible to users until then. ([@​ydah])

2.21.0 (2023-05-05)

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop](https://github.com/rubocop/rubocop) and [rubocop-rspec](https://github.com/rubocop/rubocop-rspec). These dependencies needed to be updated together.

Updates `rubocop` from 0.93.1 to 1.58.0
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.93.1...v1.58.0)

Updates `rubocop-rspec` from 1.44.1 to 2.25.0
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rspec@v1.44.1...v2.25.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: rubocop-rspec
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 12, 2023

Superseded by #2499.

@dependabot dependabot bot closed this Dec 12, 2023
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-and-rubocop-rspec-1.58.0 branch December 12, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants