Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate conflicts #800

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Validate conflicts #800

merged 7 commits into from
Nov 16, 2023

Conversation

jochenklar
Copy link
Member

@jochenklar jochenklar commented Oct 30, 2023 •
edited
Loading

This PR adds a validation to the ProjectValueSerializer that checks if the user tries to:

  • create values which are already in the database, or
  • update values which have newer versions in the database.

Related issues: #626.

@jochenklar jochenklar added this to the 2.1.0 milestone Oct 31, 2023
@jochenklar jochenklar requested a review from MyPyDavid October 31, 2023 11:28
@jochenklar jochenklar marked this pull request as ready for review October 31, 2023 11:28
MyPyDavid
MyPyDavid approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@MyPyDavid MyPyDavid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice Validator, with Tests and Mocked objects included!

@jochenklar jochenklar merged commit d8dbae1 into dev-2.1.0 Nov 16, 2023
17 checks passed
@jochenklar jochenklar deleted the validate_conflicts branch December 12, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyPyDavid MyPyDavid MyPyDavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jochenklar @MyPyDavid