DELIA-67400: Trim minidump filename length #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goruklu
requested changes
Feb 12, 2025
| @@ -136,7 +136,8 @@ bool Minidump::postHalt() | |||
| * @return Destination minidump file path string | |||
| */ | |||
| #define FIREBOLT_STATE "fireboltState" | |||
| #define MINIDUMP_FN_SEPERATOR "<#=#>" | |||
There was a problem hiding this comment.
We need to use the <#=#> seperator to make sure minidump scripts work properly.
| fileName = mUtils->getContainerId() + "_" + it->second.c_str() + "_" + timeString.str(); | ||
| if (fileName.length() > MINIDUMP_FILENAME_LENGTH) | ||
| fileName.resize(MINIDUMP_FILENAME_LENGTH); | ||
| destFile = dir + "/" + fileName + ".dmp"; |
There was a problem hiding this comment.
the 70 char limit includes the directory and the .dmp extension.
so the limit for filename is actually (70-dir.length()-4)
if dir is /opt/secure/minidumps, then limit becomes 70 - 22 - 4 = 44 chars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minidump compression is failing due to "File name too long" issue. So, limiting the minidump file name length to 70 characters
Type of Change
Requires Bitbake Recipe changes?
meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updatingSRC_REV)