tree:InBetweenRelation support #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work @smessie ! |
|
Are you planning on adding some tests/do you think tests would be useful? |
* Add support for --before, --after, --materialize-version and --last-version-only * Properly handle LDES ID and View ID * Expose new options in RDF-Connect processor * Do proper integration tests with actual (local) LDESes * Update dependencies * Fix tests * Fix identation * Do not commit coverage
|
Tests arrived |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tree:InBetweenRelationrelation with partial dateTimes.defaultTimezoneto be used with this relation, in case the LDES being consumed does not specify the timezones for the relation'stree:value.AoEfor Anywhere on Earth (will consider ≥ with value -12h & < with value + 12h),Zfor UTC,±HH:mmfor any other timezone.AoEas this will never let you miss relevant members because of different timezones being used.