feat: add systemd unit active state gauge #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lorenz Herzberger <[email protected]>
Signed-off-by: Lorenz Herzberger <[email protected]>
Signed-off-by: Lorenz Herzberger <[email protected]>
jmastr
requested changes
Apr 11, 2024
README.md
Outdated
| @@ -15,5 +15,5 @@ rpc-pass = 'password' // elementsd rpc password | |||
| rpc-user = 'user' // elementsd rpc user | |||
| service-bind = 'localhost' | |||
| service-port = 8080 | |||
| wallets = 'wallet1,wallet2' // liquid wallets | |||
| service-units = '' // systemd units | |||
There was a problem hiding this comment.
better to give a real example here, because i can see that the string passed here "only" splits at ,. So if one puts in service-units = 'foo;bar', which looks ok, the exporter won't work correctly
There was a problem hiding this comment.
and as it seems the units need to be specified with .service extension for another string split. so a good example imho would be service-units = 'foo.service,bar.service'.
Signed-off-by: Lorenz Herzberger <[email protected]>
jmastr
approved these changes
Apr 11, 2024
README.md
Outdated
| @@ -15,5 +15,5 @@ rpc-pass = 'password' // elementsd rpc password | |||
| rpc-user = 'user' // elementsd rpc user | |||
| service-bind = 'localhost' | |||
| service-port = 8080 | |||
| wallets = 'wallet1,wallet2' // liquid wallets | |||
| service-units = '' // systemd units | |||
There was a problem hiding this comment.
and as it seems the units need to be specified with .service extension for another string split. so a good example imho would be service-units = 'foo.service,bar.service'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.