Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initialization logic to accumulation register #790

Open
wants to merge 2 commits into
base: ubuffer
Choose a base branch
from

Conversation

norabarlow
Copy link
Collaborator

The previous accumulation register logic works great, except for the first time the register is used. The register value isn't initialized to anything, which messes things up.

To fix this, I

  • added selector that is true when it is the first iteration
  • move mux to in front of the adder that chooses between the bias and accum_reg. chooses bias on the first iteration; accum_reg otherwise

Note: this still outputs valid on the last iteration. We could change it to output and initialize on iteration 0 (would save a PE by removing a selector), but we would need a register to hold the in_valid signal of the previous sequence as we move to a new computation sequence. I chose not to do this for now but it can be changed later.

@norabarlow norabarlow requested a review from jeffsetter August 31, 2019 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant