Stop timer/meter #206
Merged
Stop timer/meter #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
- use map[*StandardMeter]struct{} instead of map[int64]*StandardMeter
to avoid id management pitfalls
- update documentation and examples
Use set of meters and update documentation
|
(am in the middle of a bunch of travel and a conference, will try to take a look soon.. leaving the tab open) |
mihasya
approved these changes
Nov 28, 2017
| @@ -227,7 +258,7 @@ func (ma *meterArbiter) tick() { | |||
| func (ma *meterArbiter) tickMeters() { | |||
| ma.RLock() | |||
| defer ma.RUnlock() | |||
| for _, meter := range ma.meters { | |||
| for meter := range ma.meters { | |||
There was a problem hiding this comment.
doesn't this syntax only work in newer Go? I would leave it as is to avoid breaking bw compatibility.
Edit: I see tests pass on all the old versions, disregard.
|
@mihasya thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #197
Stopto timer.Stopwhen metrics are unregistered.meter Stop()to avoid data races accessing thestoppedflag.meter Mark(), return if meter is already stopped (without panicking).