Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create generator for mocha.opts file #52

Merged
merged 16 commits into from
Oct 25, 2016
Merged

Create generator for mocha.opts file #52

merged 16 commits into from
Oct 25, 2016

Conversation

riteshe63
Copy link
Contributor

Add mocha Framework to test cases.

--reporter spec
--ui bdd
--recursive

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@riteshe63 Why so many extra spaces?

@@ -0,0 +1,39 @@
const yeoman = require('yeoman-generator');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@riteshe63 Is this file linted with eslint?

const self = this;

this.log(yosay(
'Add Testing Framework for test cases'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to say Installing Testing frameworks

));
return this.prompt([{
type: 'checkbox',
name: 'selectedFramework',
Copy link
Member

@gaurav21r gaurav21r Oct 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@riteshe63 Framework is too generic. It needs to selectedTestFramework.

},
},
/**
* Finally runs an npm install as well as installs plugins for editors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@riteshe63 Irrelevent here as we are not installing anything for editors ATM.

writing() {
// Mocha
if (_includes(this.selectedFramework, 'Mocha')) {
this.log('Configuring Mocha for mocha test cases');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Configuring default options for mocha

Copy link
Member

@gaurav21r gaurav21r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@riteshe63 Please ask @neerajsachan to submithis grunt file here.

@neerajsachan
Copy link
Collaborator

Actually, presently we are testing all unit test in the test/spec/unit//*.js file path in mocha-Test. Can we use test/unit//.js path instead of the test/spec/unit/__/.js path ? .

@riteshe63
Copy link
Contributor Author

@gaurav21r All Review is done, Please check.

@neerajsachan
Copy link
Collaborator

Change path of the folder: generators/test/templates/grunt instead of generators/grunt .

@riteshe63
Copy link
Contributor Author

@gaurav21r Please review code.

@gaurav21r gaurav21r merged commit 547e5b5 into master Oct 25, 2016
@gaurav21r gaurav21r deleted the test-generator branch October 25, 2016 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants