-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create generator for mocha.opts file #52
Conversation
--reporter spec | ||
--ui bdd | ||
--recursive | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@riteshe63 Why so many extra spaces?
@@ -0,0 +1,39 @@ | |||
const yeoman = require('yeoman-generator'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@riteshe63 Is this file linted with eslint?
const self = this; | ||
|
||
this.log(yosay( | ||
'Add Testing Framework for test cases' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to say Installing Testing frameworks
)); | ||
return this.prompt([{ | ||
type: 'checkbox', | ||
name: 'selectedFramework', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@riteshe63 Framework is too generic. It needs to selectedTestFramework
.
}, | ||
}, | ||
/** | ||
* Finally runs an npm install as well as installs plugins for editors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@riteshe63 Irrelevent here as we are not installing anything for editors ATM.
writing() { | ||
// Mocha | ||
if (_includes(this.selectedFramework, 'Mocha')) { | ||
this.log('Configuring Mocha for mocha test cases'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be Configuring default options for mocha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@riteshe63 Please ask @neerajsachan to submithis grunt file here.
…Test.js for the configuration file of the mochaTest cases in the generators/grunt folder
Actually, presently we are testing all unit test in the test/spec/unit//*.js file path in mocha-Test. Can we use test/unit//.js path instead of the test/spec/unit/__/.js path ? . |
@gaurav21r All Review is done, Please check. |
Change path of the folder: generators/test/templates/grunt instead of generators/grunt . |
@gaurav21r Please review code. |
…ructure into test-generator
Add mocha Framework to test cases.