Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inadequate escaping for incremental brewfile update. #32

Closed
MrJoy opened this issue Dec 31, 2015 · 4 comments
Closed

Inadequate escaping for incremental brewfile update. #32

MrJoy opened this issue Dec 31, 2015 · 4 comments

Comments

@MrJoy
Copy link

MrJoy commented Dec 31, 2015

App Store apps with quotes in the name have their quotes stripped when the hook for brew install runs, but the quoting is fine when brew file init / brew file dump are run.
@rcmdnk
Copy link
Owner

rcmdnk commented Jan 3, 2016

Could you please tell me any examples of such app?

@MrJoy
Copy link
Author

MrJoy commented Jan 4, 2016

  • "Lock'n'Load"
  • "Penny Arcade's On The Rain-Slick Precipice of Darkness 3"
  • "Ships N' Battles"

rcmdnk added a commit that referenced this issue Jan 4, 2016
@rcmdnk
fixed escaping for appstore, for issue #32
bf6da8e
rcmdnk added a commit that referenced this issue Jan 5, 2016
@rcmdnk
find all casks for directly installed apps (#31), fixed quotes treatm…
5c0dd4a 
…ent for appstore apps (#32)
@rcmdnk
Copy link
Owner

rcmdnk commented Jan 5, 2016

This also should be fixed at the current version (v3.7.8).

@MrJoy
Copy link
Author

MrJoy commented Jan 5, 2016

I can confirm that it appears to be fixed for me, thanks!

On Jan 4, 2016, at 6:43 PM, rcmdnk [email protected] wrote:

This also should be fixed at the current version (v3.7.8).

—
Reply to this email directly or view it on GitHub #32 (comment).

@rcmdnk rcmdnk closed this as completed Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MrJoy @rcmdnk