Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ubuntu/debian #23

Closed
wants to merge 3 commits into from
Closed

Support ubuntu/debian #23

wants to merge 3 commits into from

Conversation

redterror
Copy link

Everything pretty much works.

@rchukh
Copy link
Owner

rchukh commented Dec 9, 2014

Thanks.

I will try to take a look into it in the next few days (add some unit tests for ubuntu, update default kibana version to 4.0.0-BETA2, etc.).

Regarding the pessimistic dependencies - the ES dependency, for example, is still less than 1.0, so it may have some significant changes in 0.4/.../0.X versions, that is why I would like to keep it to ">= 0.3.10" and "< 0.4".

@redterror
Copy link
Author

Were you able to get them to resolve recently? I wasn't able to complete a berks install with the way they are specified upstream.

@rchukh rchukh added this to the 0.1.3 milestone Dec 10, 2014
@rchukh
Copy link
Owner

rchukh commented Dec 13, 2014

Java dependency - I am going to remove the patch version for it (as in this pull-request).

As for ElasticSearch...

The reason that it is not updating to 0.3.11 right now is that chef supermarket does not know about 0.3.11... the latest is 0.3.10 - https://supermarket.chef.io/cookbooks/elasticsearch
There is even a issue related to it: sous-chefs/elasticsearch#250

As for now - I will probably change the dependency to point to github.

@rhass-r7
Copy link
Contributor

👍 I am happy to see both this cookbook and this patch. @redterror You may want to also add ubuntu and/or debian to the platforms in .kitchen.yml before this patch gets landed.

@rhass-r7
Copy link
Contributor

In addition to my previous suggestion, you may want to consider the follow patch:

diff --git a/metadata.rb b/metadata.rb
index 0d04698..4728b41 100644
--- a/metadata.rb
+++ b/metadata.rb
@@ -23,7 +23,8 @@ EOH
 depends 'chef-sugar', '~> 2.4'
 depends 'line', '~> 0.5'
 depends 'ark', '~> 0.9'
 depends 'java', '~> 1.28'
+depends 'apt', '~> 2.6.0'

 # Optional dependencies
 # FIX: 'depends' because of https://github.com/acrmp/foodcritic/issues/159
diff --git a/recipes/dependencies.rb b/recipes/dependencies.rb
index 37ac2b7..3e85dd3 100644
--- a/recipes/dependencies.rb
+++ b/recipes/dependencies.rb
@@ -5,6 +5,7 @@
 include_recipe 'chef-sugar::default'

 if node['kibana']['dependency']['install_java']
+  if platform_family?('debian') then include_recipe 'apt::default' end
   include_recipe 'java::default'
 else
   ruby_block 'check_java' do

In my tests via test-kitchen, I was unable to converge the node when installing java due to the apt cache being stale. Technically, this is a bug in the java cookbook, but I will leave it here for the consideration of you both. Pull-Request submitted to @redterror with the provided patch.

@rchukh rchukh mentioned this pull request Dec 14, 2014
@rchukh
Copy link
Owner

rchukh commented Dec 14, 2014

Thanks!

I will close this pull-request and create a separate from @redterror repo (to the ubuntu branch instead master branch).

After that I'll merge @rhass-r7 changes, and will do some tests before merging them into master.

@rchukh rchukh closed this Dec 14, 2014
@rchukh
Copy link
Owner

rchukh commented Dec 14, 2014

@redterror , @rhass-r7
I have just released a 0.2.0 version with all those changes that were provided, and some additional fixes.

https://supermarket.chef.io/cookbooks/chamber-kibana/versions/0.2.0

@redterror
Copy link
Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants