introduce error objects #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
until now errors were always string. this commit changes this to error Objects, with the intention to be able to programmatically handle errors better (without string parsing). Example Use Case: Crawling a website and checking if links are valid. Current State: when a link points to a ressource which is not available, it returns an error with a string containing 404. State with this commit, it returns an error with an errorType, statusCode etc, which can be processed easily.
|
Error codes work well for HTTP errors, but the error system should be consistent. I agree with implementing a better error system, but non-HTTP errors should use the same system. This means that errors like failed logins and no results for selectors should also throw an error object with an error code. Also, try not to use Object.assign so the code works on ES5 platforms too. |
|
Discussion in #135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
until now errors were always string. this commit changes this to error
Objects, with the intention to be able to programmatically handle
errors better (without string parsing).
Example Use Case: Crawling a website and checking if links are valid.
Current State: when a link points to a ressource which is not
available, it returns an error with a string containing 404. State with
this commit, it returns an error with an errorType, statusCode etc,
which can be processed easily.