-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate from gRPC to http (WIP) #73
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
where an interface such as `IDeployData` has: deployer?: Uint8Array | null; the class will have: deployer: Uint8Array; so flow complains about the mismatch. Solution: mark the field in the interface covariant: +deployer?: Uint8Array | null;
flowgen generates "CLASS mixins IFACE"; I don't see that documented anywhere. "CLASS implements IFACE" seems to work.
avoid "cannot use value as type" or some such
allow .js in imports for browser context
from liquid-democracy Sep 13 c406f2da0ac
- update blake2 dep - package.json lint for scripts
- fix rnode-openapi-schama types
- update rhopm to use proxy APIs: - update proxy to provide checkForDeployInfo, listenAtDeployId, - export makeAccount (works in liquid-democracy Jakefile) - replace signWithKey - DataForDeploy type is gone - clock() is async (no reading the clock twice in the same turn!) - export makeConnection (untested) - hoist readFileSync out of shardIO
yarn complained about 0.9.25.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is just a tiny start; it just does status.
note that protobuf
DeployDataProto
is still neededref:
https://github.com/rchain/rchain/blob/ca9a3bc5f7b4332899968e2d5320698c9b6e07db/integration-tests/test/http_client.py