Rnode 0.9 update: Either.proto etc. #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flow-check still in progress
all tests pass. yay!
dckc
changed the title
dckc
commented
Apr 5, 2019
|
@cboscolo it took me a while, but I think this is done now. |
JoshOrndorff
approved these changes
Apr 5, 2019
dckc
commented
Apr 5, 2019
| @@ -273,23 +259,20 @@ function RNode(grpc /*: grpcT */, endPoint /*: { host: string, port: number } */ | |||
| * JOINed set of names in the tuplespace | |||
| * @memberof RNode | |||
| * @param pars The names onwhich to listen | |||
| * @return promise for ContinuationsWithBlockInfo | |||
| * @return promise for DataWithBlockInfo | |||
good catch, Joshy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #60