Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsnext:main and module values in package.json are incorrect #359

Closed
jprosevear opened this issue Mar 9, 2020 · 2 comments
Closed

jsnext:main and module values in package.json are incorrect #359

jprosevear opened this issue Mar 9, 2020 · 2 comments

Comments

@jprosevear
Copy link

jsnext:main and module values in package.json are incorrect and can cause build breakage. Previously they did not cause a problem because they were pointing to invalid values and essentially not used.

Since both point to modules that require more than ES2015 syntax, I believe the simplest solution is both should be removed then tools like babel/webpack will use dist/ instead which is already transpiled.

Alternately transpile the module file.

jsforum/jsforum#5
https://shuheikagawa.com/blog/2017/01/05/main-jsnext-main-and-module/

@jprosevear
Copy link
Author

PR #360 for this

@rcdexta
Copy link
Owner

rcdexta commented Apr 4, 2020

Addressed in v2.2.5

@rcdexta rcdexta closed this as completed Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants