add precommit #84
Merged
add precommit #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
|
HI @callumrollo , |
|
ok I think this is ready @rcaneill . Bit of a monster! Mostly spelling corrections and clearing out unused imports |
rcaneill
reviewed
Feb 15, 2024
There was a problem hiding this comment.
It seems incorrect here to replace nam by name as name is already used in the for loop (line 27).
rcaneill
reviewed
Feb 15, 2024
rcaneill
requested changes
Feb 15, 2024
rcaneill
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR adds some basic pre-commit hooks. This pre-commit will, among other things, satisfy the pyopensci requirement for automated linting
The linting is picking up quite a few PEP8 and spelling errors atm. These will need to be fixed. This also should be added to CI.
@rcaneill are you working on something similar already, or should I complete this PR?