Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change open options #27

Merged
merged 6 commits into from
May 31, 2022
Merged

Change open options #27

merged 6 commits into from
May 31, 2022

Conversation

rcaneill
Copy link
Owner

No description provided.

@rcaneill rcaneill linked an issue May 29, 2022 that may be closed by this pull request
@rcaneill
Copy link
Owner Author

rcaneill commented May 29, 2022

A little comment to organize my ideas.
Here is a list of what xnemogcm should be able to handle:

A. Open

  1. Give it files named grid_X, and open_nemo will open the files and will know how to place each variable on the proper grid point
  2. Give it random file names, and open_nemo will open the files and will know how to place each variable on the proper grid point based on the 'description' attribute
  3. Give it random file names, with a dictionary of what file is on what grid point, and open_nemo will open the files and place each variable on the proper grid point

B. Process

  1. Give it datasets that have the 'description' attribute and let xnemogcm set each variable
  2. Give it datasets with a dictionary on where to set each dataset (e.g. {'T':[ds1, ds2], 'U':ds3}) (or a list of tuple, e.g. [(ds1, 'T'), (ds2, 'U')])

How to do?

For A1, A2, and A3, could simply be 1) open and 2) process with method B2.

For B1, could create the dict and then call B2

@rcaneill
Copy link
Owner Author

rcaneill commented May 29, 2022

Roadmap

  • Implement B2
  • implement B1
  • implement A3
  • implement A1
  • implement A2

@rcaneill
Copy link
Owner Author

I will not implement A3, in case in a (more or less) future I implement an automatic grid detection based on the domcfg

@rcaneill rcaneill merged commit 3d0709b into master May 31, 2022
@rcaneill rcaneill deleted the change_open_options branch April 19, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Help wanted] Change backend
1 participant