Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to parameters and preferences #14

Merged
merged 29 commits into from
Apr 4, 2023
Merged

Improvements to parameters and preferences #14

merged 29 commits into from
Apr 4, 2023

Conversation

rbeyer
Copy link
Owner

@rbeyer rbeyer commented Mar 21, 2023

Description

  • New kalasiris.set_persistent_preferences() functionality so that a library user can set a persistent preferences path rather than having to enter it with each kalasiris function run. Addresses Issue Make parsing stdout more robust to user IsisPreferences #11.
  • Can now also pass parameters that do not take an argument to ISIS in a manner similar to how you'd write them on the command line (e.g. getkey("-help")) in addition to the "old" way (e.g. getkey("help__")).

Related Issue

Would close #11 .

How Has This Been Tested?

  • make docs
  • make test-all

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Licensing:

This project is released under the LICENSE.

  • I claim copyrights on my contributions in this pull request, and I provide those contributions via this pull request under the same license terms that the pvl project uses.

@rbeyer rbeyer mentioned this pull request Mar 21, 2023
@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Merging #14 (cba3cfb) into main (d22e502) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   92.50%   92.60%   +0.10%     
==========================================
  Files          12       12              
  Lines         480      487       +7     
==========================================
+ Hits          444      451       +7     
  Misses         36       36              
Impacted Files Coverage Δ
kalasiris/cubenormfile.py 88.57% <ø> (-0.32%) ⬇️
kalasiris/__init__.py 100.00% <100.00%> (ø)
kalasiris/kalasiris.py 92.10% <100.00%> (+2.39%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rbeyer added 28 commits April 2, 2023 08:54
…t take an argument, and cleared up some documentation.
@rbeyer rbeyer merged commit 5651a25 into main Apr 4, 2023
@rbeyer rbeyer deleted the preferences-11 branch July 10, 2024 22:55
@rbeyer rbeyer restored the preferences-11 branch July 10, 2024 22:55
@rbeyer rbeyer deleted the preferences-11 branch July 10, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make parsing stdout more robust to user IsisPreferences
1 participant