[rubocop] Fixes build #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the change to the gemspec file does stop the tests from running on Ruby 1.9.3, but the gem itself should still work. |
|
I'd really like to have the tests back in 1.9.3, otherwise we won't notice breakage. We might be okay with it breaking (1.9.3 is EOL) but we need to know. Any other suggestions other than disabling the Cop? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build fails with Rubocop v0.53.0
Fixes:
File.expand_path(__dir__)overFile.expand_path('..', __FILE__)rubocop/rubocop#4008UncommunicativeMethodParamNamecop: New Cop: Implement some parameter name check cop rubocop/rubocop#3666