Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

Add interna_duration_millisto Raw Service View #108

Merged
merged 6 commits into from
Dec 5, 2022

Conversation

suddendust
Copy link

  • Adding null so that the default value while reading is null (as 0 is a valid value of this metric, we ideally do not want records missing this field to be deserialised with this value as 0).

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #108 (d3ee009) into rzp_main (10db587) will increase coverage by 0.72%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##             rzp_main     #108      +/-   ##
==============================================
+ Coverage       79.67%   80.40%   +0.72%     
- Complexity       1338     1342       +4     
==============================================
  Files             119      119              
  Lines            5318     5322       +4     
  Branches          494      495       +1     
==============================================
+ Hits             4237     4279      +42     
+ Misses            857      813      -44     
- Partials          224      230       +6     
Flag Coverage Δ
unit 80.40% <100.00%> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...wgenerator/generators/RawServiceViewGenerator.java 77.77% <100.00%> (+77.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link

@13shivam 13shivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM!

@github-actions

This comment has been minimized.

@suddendust suddendust merged commit 562c937 into rzp_main Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Unit Test Results

  78 files  +1    78 suites  +1   59s ⏱️ +4s
403 tests +1  401 ✔️ +1  2 💤 ±0  0 ❌ ±0 

Results for commit 562c937. ± Comparison against base commit 10db587.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants