This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
forked from hypertrace/hypertrace-ingester
-
Notifications
You must be signed in to change notification settings - Fork 4
Add interna_duration_millis
to Raw Service View
#108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## rzp_main #108 +/- ##
==============================================
+ Coverage 79.67% 80.40% +0.72%
- Complexity 1338 1342 +4
==============================================
Files 119 119
Lines 5318 5322 +4
Branches 494 495 +1
==============================================
+ Hits 4237 4279 +42
+ Misses 857 813 -44
- Partials 224 230 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
13shivam
suggested changes
Dec 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM!
hypertrace-view-generator/hypertrace-view-generator-api/src/main/avro/SpanEventView.avdl
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
13shivam
approved these changes
Dec 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
(as 0 is a valid value of this metric, we ideally do not want records missing this field to be deserialised with this value as 0).