Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: put method in http postprocessor #217

Merged
merged 11 commits into from
Nov 24, 2022
Merged

feat: put method in http postprocessor #217

merged 11 commits into from
Nov 24, 2022

Conversation

batrov
Copy link
Contributor

@batrov batrov commented Nov 17, 2022

Add PUT functionality to http postprocessor

@vercel
Copy link

vercel bot commented Nov 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dagger ✅ Ready (Inspect) Visit Preview Nov 17, 2022 at 9:39AM (UTC)

@batrov batrov force-pushed the put-http-postprocessor branch from 44a7150 to 39867a7 Compare November 17, 2022 05:12
@Meghajit
Copy link
Member

Meghajit commented Nov 17, 2022 •
edited
Loading

We should not commit this file dagger-common/src/generated-sources/descriptors/dagger-descriptors.bin
It's an autogenerated one and only used for quickstart. I'll create an issue to add this in .gitignore

@batrov
Copy link
Contributor Author

batrov commented Nov 21, 2022

We should not commit this file dagger-common/src/generated-sources/descriptors/dagger-descriptors.bin It's an autogenerated one and only used for quickstart. I'll create an issue to add this in .gitignore

updated and added in gitignore

@Meghajit
Copy link
Member

We will need to add this new feature in the documentation as well.
Can you also add/edit the necessary sections here ?

@Meghajit Meghajit added the enhancement New feature or request label Nov 22, 2022
@Meghajit Meghajit linked an issue Nov 22, 2022 that may be closed by this pull request
feat: Add support for HTTP PUT request in Http PostProcessor #218
Closed
@Meghajit Meghajit merged commit 0e36063 into raystack:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meghajit Meghajit Meghajit left review comments

@prakharmathur82 prakharmathur82 prakharmathur82 left review comments

Assignees

@batrov batrov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add support for HTTP PUT request in Http PostProcessor
3 participants
@batrov @Meghajit @prakharmathur82