Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rcore][RGFW] Add new backend option: PLATFORM_WEB_RGFW #4480

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[rcore][RGFW] Add new backend option: PLATFORM_WEB_RGFW #4480

wants to merge 9 commits into from
+301 −258

Conversation

ColleagueRiley
Copy link
Contributor

This is a WIP pull request.

@ColleagueRiley ColleagueRiley marked this pull request as draft November 10, 2024 22:59
@ColleagueRiley
Copy link
Contributor Author

ColleagueRiley commented Nov 10, 2024 •
edited
Loading

Issues thus far:

  • Fullscreen toggle causing screen to go black

  • more testing has to be done

@raysan5
Copy link
Owner

raysan5 commented Nov 14, 2024

@ColleagueRiley Thank you very much for working on this new platform backend! Exiting to have a GLFW alternative for PLATFORM_WEB! Keep up the great work!

@raysan5 raysan5 changed the title Add PLATFORM_WEB_RGFW [rcore][RGFW] Add new backend option: PLATFORM_WEB_RGFW Nov 16, 2024
orcmid
orcmid reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@orcmid orcmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raysan5 @ColleagueRiley
Is it still the raylib practice not to modify externals since the latest ones upstream are included at each release?

Is an exception being made to maintain RGFW.h under raylib?

Musing: The platforms changes setup is intriguing. I am not quite clear how one deals with maintenance and confirmation across them, especially with raylib changes that impact rcore.c. Not my problem, but something that catches my eye.

@ColleagueRiley
Copy link
Contributor Author

ColleagueRiley commented Nov 21, 2024 •
edited
Loading

@raysan5 The only remaining issue with the web platform is the fullscreen toggle.

@ColleagueRiley ColleagueRiley marked this pull request as ready for review November 25, 2024 11:51
raysan5
raysan5 reviewed Nov 26, 2024
View reviewed changes
Makefile
@@ -0,0 +1,8 @@
EXAMPLE = core/core_input_gamepad
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this file shouldn't be in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raysan5 raysan5 raysan5 left review comments

@orcmid orcmid orcmid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ColleagueRiley @raysan5 @orcmid