-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update brew extension #16069
Update brew extension #16069
Conversation
Thank you for your first contribution! 🎉 🔔 @nhojb @Aayush9029 @mathieudutour @urwrstkn8mare @ashokbaruaakas @MillerApps @pernielsentikaer @jfkisafk @vpukhanov @j3lte you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. Due to our current reduced availability, the initial review may take up to 10-15 business days 🎄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for the contribution 👏
@alexander-cato can you mark the PR as non-draft so I can merge? Thanks. |
3c48abe
to
075164f
Compare
Thanks for the quick review @nhojb! Apologies for the initially confusing git history; I was unfamiliar with the operation of the Raycast publish command and surprised when it automatically opened a PR before I was quite finished. I have since rebased the PR branch with a more granular commit history for easier review and future reference. |
Published to the Raycast Store: |
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
Overview
This pull request primarily introduces support for selecting Ghostty as a terminal option.
Additionally, several dependencies were updated to the latest stable versions. All linter errors have been addressed, and some sections of the code have been refactored to enhance readability and consistency.
Areas for improvement
There are instances where Ghostty does not respond to AppleScript commands promptly, which can result in the desired command being entered into the main Raycast input box instead. This issue seems to occur more frequently when Ghostty is running in a minimized window. Further testing is required to identify the root cause and to implement necessary improvements to the AppleScript. Despite this, the current implementation functions relatively reliably, especially when Ghostty is not already running.
The dependency "node-fetch" should be updated to the latest stable version. However, doing so currently causes build errors that need to be resolved. Further investigation is required to address these issues and ensure compatibility with the updated version.
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder