Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brew extension #16069

Merged
merged 6 commits into from
Jan 2, 2025
Merged

Update brew extension #16069

merged 6 commits into from
Jan 2, 2025

Conversation

alexander-cato
Copy link
Contributor

@alexander-cato alexander-cato commented Dec 28, 2024

Description

Overview

  • This pull request primarily introduces support for selecting Ghostty as a terminal option.

  • Additionally, several dependencies were updated to the latest stable versions. All linter errors have been addressed, and some sections of the code have been refactored to enhance readability and consistency.

Areas for improvement

  • There are instances where Ghostty does not respond to AppleScript commands promptly, which can result in the desired command being entered into the main Raycast input box instead. This issue seems to occur more frequently when Ghostty is running in a minimized window. Further testing is required to identify the root cause and to implement necessary improvements to the AppleScript. Despite this, the current implementation functions relatively reliably, especially when Ghostty is not already running.

  • The dependency "node-fetch" should be updated to the latest stable version. However, doing so currently causes build errors that need to be resolved. Further investigation is required to address these issues and ensure compatibility with the updated version.

Screencast

CleanShot 2024-12-31 at 02 28 26 CleanShot 2024-12-31 at 02 31 12
Extension Configuration Install Command

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: brew Issues related to the brew extension labels Dec 28, 2024
@raycastbot
Copy link
Collaborator

raycastbot commented Dec 28, 2024

Thank you for your first contribution! 🎉

🔔 @nhojb @Aayush9029 @mathieudutour @urwrstkn8mare @ashokbaruaakas @MillerApps @pernielsentikaer @jfkisafk @vpukhanov @j3lte you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

Due to our current reduced availability, the initial review may take up to 10-15 business days 🎄

@alexander-cato alexander-cato marked this pull request as draft December 28, 2024 16:51
Copy link
Contributor

@nhojb nhojb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the contribution 👏

@nhojb
Copy link
Contributor

nhojb commented Dec 29, 2024

@alexander-cato can you mark the PR as non-draft so I can merge? Thanks.

@alexander-cato
Copy link
Contributor Author

Thanks for the quick review @nhojb!

Apologies for the initially confusing git history; I was unfamiliar with the operation of the Raycast publish command and surprised when it automatically opened a PR before I was quite finished.

I have since rebased the PR branch with a more granular commit history for easier review and future reference.
The code remains largely unchanged compared initial review.

@alexander-cato alexander-cato marked this pull request as ready for review December 31, 2024 08:45
@raycastbot raycastbot merged commit 1e558d6 into raycast:main Jan 2, 2025
2 checks passed
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Published to the Raycast Store:
https://raycast.com/nhojb/brew

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension: brew Issues related to the brew extension extension fix / improvement Label for PRs with extension's fix improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants