Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding range to tags #524

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

kkrime
Copy link
Contributor

@kkrime kkrime commented Nov 19, 2024

Adding range to the :Go.*Tag commands

@ray-x I'm not sure I understand the :GoModifyTag command, it's not in the documentation, do we really need it?

@kkrime kkrime marked this pull request as ready for review November 21, 2024 04:06
@kkrime
Copy link
Contributor Author

kkrime commented Nov 21, 2024

@ray-x I'll fix the tests, but before I do so, can you let me know what you think about the changes I've made?

@ray-x
Copy link
Owner

ray-x commented Dec 1, 2024

Thanks for the PR
Could you check the action errors lua/go/tags.lua:114: attempt to index local 'opts' (a nil value) ?

@kkrime
Copy link
Contributor Author

kkrime commented Dec 7, 2024

I'm having trouble running the git hub actions locally using act

@ray-x are you able to run the github actions locally and if so what type of machien are you using??
(I'm using osx on m1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants